Replace winapi dependency with windows #28
Conversation
opener/src/windows/reveal.rs
Outdated
| let item_id_list = unsafe { ILCreateFromPathW(PCWSTR::from_raw(path.as_ptr())) }; | ||
| unsafe { SHOpenFolderAndSelectItems(item_id_list, None, 0) }?; |
There was a problem hiding this comment.
This is one of those things I'm not sure of: do we still need to call ILFree on item_id_list after SHOpen...?
There was a problem hiding this comment.
Yes, and it needs to be called even if SHOpenFolderAndSelectItems() fails. The same goes for CoUninitialize().
Since normpath was [added][1], opener has depended on both winapi (directly) and windows-sys (transitively). This commit replaces usage of winapi with the windows crate so that it only depends on a single windows API crate. Additionally, the windows crate includes some functions that were manually linked in opener, so those manual links were able to be cleaned up. [1]: 3b48ee0
skipkayhil
force-pushed
the
hm-use-windows
branch
from
1f942b5
to
9fb4494
Compare
|
Friendly bump 🙂 Anything needed from me? |
|
I just pushed a commit fixing some style nits. However, I've just realized we're using the
The first option is simpler, but I believe there's some edge cases where |
|
I've switched over to |
Since normpath was added, opener has depended on both winapi (directly) and windows-sys (transitively).
This commit replaces usage of winapi with the windows crate so that it only depends on a single windows API crate. Additionally, the windows crate includes some functions that were manually linked in opener, so those manual links were able to be cleaned up.
I'm not very experienced with unsafe Rust 😅. Any feedback is appreciated!